Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kafka consumergroup list): fix reference to the wrong i18n ID #775

Merged
merged 1 commit into from
Jul 1, 2021
Merged

fix(kafka consumergroup list): fix reference to the wrong i18n ID #775

merged 1 commit into from
Jul 1, 2021

Conversation

craicoverflow
Copy link
Contributor

@craicoverflow craicoverflow commented Jul 1, 2021 •
edited
Loading

Closes #773

Verification Steps

Run rhoas kafka consumergroup list on an instance you do not own. You should get a nice message like this:

Error: you are unauthorized to list these topics

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change
  • Other (please specify)

Checklist

  • Documentation added for the feature
  • CI and all relevant tests are passing
  • Code Review completed
  • Verified independently by reviewer

@craicoverflow craicoverflow merged commit 5a798dd into main Jul 1, 2021
@craicoverflow craicoverflow deleted the fix/panic branch July 1, 2021 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkpattnaik780 rkpattnaik780 rkpattnaik780 approved these changes

@wtrocki wtrocki wtrocki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

panic: message "kafka.consumerGroup.list.common.error.unauthorized" not found in language "en"
3 participants
@craicoverflow @wtrocki @rkpattnaik780